Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using -fsanitize-blacklist=file.txt disables the default ASan blacklist #22805

Closed
timurrrr opened this issue Feb 2, 2015 · 6 comments
Closed

Using -fsanitize-blacklist=file.txt disables the default ASan blacklist #22805

timurrrr opened this issue Feb 2, 2015 · 6 comments
Labels
bugzilla Issues migrated from bugzilla clang:driver 'clang' and 'clang++' user-facing binaries. Not 'clang-cl'

Comments

@timurrrr
Copy link
Contributor

timurrrr commented Feb 2, 2015

Bugzilla Link 22431
Resolution FIXED
Resolved on Feb 09, 2015 06:48
Version trunk
OS Windows NT
CC @eugenis,@ramosian-glider,@zmodem,@rnk

Extended Description

This change fails at r227799:
diff --git test/asan/TestCases/Windows/iostream_sbo.cc test/asan/TestCases/Windows/iostream_sbo.cc
index 96a8b80..ffcd530 100644
--- test/asan/TestCases/Windows/iostream_sbo.cc
+++ test/asan/TestCases/Windows/iostream_sbo.cc
@@ -1,5 +1,10 @@
+// First, check this works with the default blacklist:
// RUN: %clang_cl_asan -O0 %s -Fe%t
// RUN: echo "42" | %run %t 2>&1 | FileCheck %s
+//
+// Then, make sure it still works when a user uses his own blacklist file:
+// RUN: %clang_cl_asan -O0 %s -fsanitize-blacklist=%p/../Helpers/initialization-blacklist.txt -Fe%t2
+// RUN: echo "42" | %run %t2 2>&1 | FileCheck %s

#include

Please note the default blacklist for windows is not empty due to http://goo.gl/L4qqUG

I'd argue that ASan should merge the user-specified blacklist with the default one rather than just replace.
@timurrrr
Copy link
Contributor Author

timurrrr commented Feb 2, 2015

Alexey,
Can you please take a look?

@timurrrr
Copy link
Contributor Author

timurrrr commented Feb 2, 2015

Just for the record, once this is fixed we should update Clang/Win revision used in Chromium and revert https://crrev.com/7949a66919a6d288451e3a818a843ea39025bd74

@rnk
Copy link
Collaborator

rnk commented Feb 2, 2015

Be careful when rolling, as seh changes are causing instability.

@timurrrr
Copy link
Contributor Author

timurrrr commented Feb 2, 2015

Sure, I'll make sure to check the FYI bot first.

@llvmbot
Copy link
Collaborator

llvmbot commented Feb 4, 2015

Should be fixed by r228156.

@timurrrr
Copy link
Contributor Author

timurrrr commented Feb 9, 2015

r228573 adds an extra ASan/Win test case as in comment #​0

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 9, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bugzilla Issues migrated from bugzilla clang:driver 'clang' and 'clang++' user-facing binaries. Not 'clang-cl'
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rnk @timurrrr @llvmbot