Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No email with 'LGTM' sent when a revision is just marked as marked as "accepted" #26145

Closed
chandlerc opened this issue Dec 8, 2015 · 5 comments
Closed

No email with 'LGTM' sent when a revision is just marked as marked as "accepted" #26145

chandlerc opened this issue Dec 8, 2015 · 5 comments
Labels
bugzilla Issues migrated from bugzilla infrastructure Bugs about LLVM infrastructure website

Comments

@chandlerc
Copy link
Member

Bugzilla Link 25771
Version unspecified
OS All

Extended Description

This causes folks to sometimes mark a revision accepted without adding an explicit comment, and as a consequence no email gets sent to the mailing list. This is important because folks watching the mailing list may not realize that there was an explicit LGTM given in the review.
@llvmbot
Copy link
Collaborator

llvmbot commented Dec 8, 2015

I thought that had been fixed? It doesn't say LGTM, but it says "accepted and is ready to land" iirc?

@chandlerc
Copy link
Member Author

I thought that had been fixed? It doesn't say LGTM, but it says "accepted
and is ready to land" iirc?

It sends a private email to people not including the subscribers saying that. =/

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 10, 2021
@xgupta
Copy link
Contributor

xgupta commented Jun 10, 2022

Still an issue, maybe llvm-iwg https://github.com/llvm/llvm-iwg can help.

@xgupta xgupta added the infrastructure Bugs about LLVM infrastructure label Jun 10, 2022
@llvmbot
Copy link
Collaborator

llvmbot commented Jun 10, 2022

@llvm/issue-subscribers-infrastructure

@xgupta
Copy link
Contributor

xgupta commented Jun 27, 2023

This is fixed.

@xgupta xgupta closed this as completed Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bugzilla Issues migrated from bugzilla infrastructure Bugs about LLVM infrastructure website
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chandlerc @llvmbot @xgupta