Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GlobalISel] Value to vreg during IR to MachineInstr translation for aggregate type #26535

Closed
qcolombet opened this issue Jan 15, 2016 · 6 comments
Assignees
Labels
bugzilla Issues migrated from bugzilla llvm:globalisel

Comments

@qcolombet
Copy link
Collaborator

Bugzilla Link 26161
Resolution FIXED
Resolved on May 18, 2018 06:34
Version trunk
OS All
Blocks #34708 #34709 #34707
CC @aemerson,@adibiagio,@bcardosolopes,@hfinkel

Extended Description

The design to handle aggregate types during IR translation in GlobalISel will need to be revisited to at least acknowledge that we choose the right approach.

At first, this is not critical that we don’t support aggregate types, thus a simple mapping one Value* to one Vreg is perfectly fine.

When we would add the support for such types, we have basically two options:

  1. Replicate SDAG solution, i.e., more or less map one Value* to a list of Vregs (one Vreg per component).
  2. Keep the mapping simple, i.e., one Value* to one (big) Vreg.

The pros and cons are discussed in the following thread:
http://lists.llvm.org/pipermail/llvm-dev/2016-January/094049.html

Although #​2 seems preferable, we don’t have any actual experience on how well we would be to optimize this representation.

@qcolombet
Copy link
Collaborator Author

assigned to @aemerson

@aemerson
Copy link
Contributor

We now split aggregates into multiple Regs as of r332449.

@aemerson
Copy link
Contributor

mentioned in issue #34707

1 similar comment
@ostannard
Copy link
Collaborator

mentioned in issue #34707

@aemerson
Copy link
Contributor

mentioned in issue #34709

@ostannard
Copy link
Collaborator

mentioned in issue #34708

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla Issues migrated from bugzilla llvm:globalisel
Projects
None yet
Development

No branches or pull requests

3 participants