Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression(263110:263111): TestCases/Float/cast-overflow.cpp started failing on the Windows bot #27293

Closed
nico opened this issue Mar 12, 2016 · 8 comments
Closed

Regression(263110:263111): TestCases/Float/cast-overflow.cpp started failing on the Windows bot #27293

nico opened this issue Mar 12, 2016 · 8 comments
Labels
bugzilla Issues migrated from bugzilla compiler-rt

Comments

@nico
Copy link
Contributor

nico commented Mar 12, 2016

Bugzilla Link 26919
Resolution FIXED
Resolved on Mar 14, 2016 12:34
Version unspecified
OS Linux
CC @Delena,@filcab

Extended Description

http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/10500

Script:

D:/buildslave/clang-x64-ninja-win7/stage1/./bin/clang.exe -fsanitize=float-cast-overflow D:\buildslave\clang-x64-ninja-win7\llvm\projects\compiler-rt\test\ubsan\TestCases\Float\cast-overflow.cpp -o D:\buildslave\clang-x64-ninja-win7\stage1\projects\compiler-rt\test\ubsan\Standalone-x86_64\TestCases\Float\Output\cast-overflow.cpp.tmp
D:\buildslave\clang-x64-ninja-win7\stage1\projects\compiler-rt\test\ubsan\Standalone-x86_64\TestCases\Float\Output\cast-overflow.cpp.tmp _
env UBSAN_OPTIONS=print_summary=1:report_error_type=1 D:\buildslave\clang-x64-ninja-win7\stage1\projects\compiler-rt\test\ubsan\Standalone-x86_64\TestCases\Float\Output\cast-overflow.cpp.tmp 0 2>&1 | FileCheck D:\buildslave\clang-x64-ninja-win7\llvm\projects\compiler-rt\test\ubsan\TestCases\Float\cast-overflow.cpp --check-prefix=CHECK-0
D:\buildslave\clang-x64-ninja-win7\stage1\projects\compiler-rt\test\ubsan\Standalone-x86_64\TestCases\Float\Output\cast-overflow.cpp.tmp 1 2>&1 | FileCheck D:\buildslave\clang-x64-ninja-win7\llvm\projects\compiler-rt\test\ubsan\TestCases\Float\cast-overflow.cpp --check-prefix=CHECK-1
D:\buildslave\clang-x64-ninja-win7\stage1\projects\compiler-rt\test\ubsan\Standalone-x86_64\TestCases\Float\Output\cast-overflow.cpp.tmp 2 2>&1 | FileCheck D:\buildslave\clang-x64-ninja-win7\llvm\projects\compiler-rt\test\ubsan\TestCases\Float\cast-overflow.cpp --check-prefix=CHECK-2
D:\buildslave\clang-x64-ninja-win7\stage1\projects\compiler-rt\test\ubsan\Standalone-x86_64\TestCases\Float\Output\cast-overflow.cpp.tmp 3 2>&1 | FileCheck D:\buildslave\clang-x64-ninja-win7\llvm\projects\compiler-rt\test\ubsan\TestCases\Float\cast-overflow.cpp --check-prefix=CHECK-3
D:\buildslave\clang-x64-ninja-win7\stage1\projects\compiler-rt\test\ubsan\Standalone-x86_64\TestCases\Float\Output\cast-overflow.cpp.tmp 4 2>&1 | FileCheck D:\buildslave\clang-x64-ninja-win7\llvm\projects\compiler-rt\test\ubsan\TestCases\Float\cast-overflow.cpp --check-prefix=CHECK-4
D:\buildslave\clang-x64-ninja-win7\stage1\projects\compiler-rt\test\ubsan\Standalone-x86_64\TestCases\Float\Output\cast-overflow.cpp.tmp 5 2>&1 | FileCheck D:\buildslave\clang-x64-ninja-win7\llvm\projects\compiler-rt\test\ubsan\TestCases\Float\cast-overflow.cpp --check-prefix=CHECK-5
D:\buildslave\clang-x64-ninja-win7\stage1\projects\compiler-rt\test\ubsan\Standalone-x86_64\TestCases\Float\Output\cast-overflow.cpp.tmp 6 2>&1 | FileCheck D:\buildslave\clang-x64-ninja-win7\llvm\projects\compiler-rt\test\ubsan\TestCases\Float\cast-overflow.cpp --check-prefix=CHECK-6
not D:\buildslave\clang-x64-ninja-win7\stage1\projects\compiler-rt\test\ubsan\Standalone-x86_64\TestCases\Float\Output\cast-overflow.cpp.tmp 9 2>&1 | FileCheck D:\buildslave\clang-x64-ninja-win7\llvm\projects\compiler-rt\test\ubsan\TestCases\Float\cast-overflow.cpp --check-prefix=CHECK-9

Exit Code: 1

Command Output (stdout):

Command 0: "D:/buildslave/clang-x64-ninja-win7/stage1/./bin/clang.exe" "-fsanitize=float-cast-overflow" "D:\buildslave\clang-x64-ninja-win7\llvm\projects\compiler-rt\test\ubsan\TestCases\Float\cast-overflow.cpp" "-o" "D:\buildslave\clang-x64-ninja-win7\stage1\projects\compiler-rt\test\ubsan\Standalone-x86_64\TestCases\Float\Output\cast-overflow.cpp.tmp"
Command 0 Result: 0
Command 0 Output:
Creating library D:\buildslave\clang-x64-ninja-win7\stage1\projects\compiler-rt\test\ubsan\Standalone-x86_64\TestCases\Float\Output\cast-overflow.cpp.lib and object D:\buildslave\clang-x64-ninja-win7\stage1\projects\compiler-rt\test\ubsan\Standalone-x86_64\TestCases\Float\Output\cast-overflow.cpp.exp

Command 0 Stderr:
D:\buildslave\clang-x64-ninja-win7\llvm\projects\compiler-rt\test\ubsan\TestCases\Float\cast-overflow.cpp:45:3: warning: expression result unused [-Wunused-value]

(int)MaxFloatRepresentableAsInt; // ok

^ ~~~~~~~~~~~~~~~~~~~~~~~~~~

D:\buildslave\clang-x64-ninja-win7\llvm\projects\compiler-rt\test\ubsan\TestCases\Float\cast-overflow.cpp:46:3: warning: expression result unused [-Wunused-value]

(int)-MaxFloatRepresentableAsInt; // ok

^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~

D:\buildslave\clang-x64-ninja-win7\llvm\projects\compiler-rt\test\ubsan\TestCases\Float\cast-overflow.cpp:49:3: warning: expression result unused [-Wunused-value]

(int)MinFloatRepresentableAsInt; // ok

^ ~~~~~~~~~~~~~~~~~~~~~~~~~~

D:\buildslave\clang-x64-ninja-win7\llvm\projects\compiler-rt\test\ubsan\TestCases\Float\cast-overflow.cpp:52:3: warning: expression result unused [-Wunused-value]

(unsigned int)MaxFloatRepresentableAsUInt; // ok

^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~

4 warnings generated.

Command 1: "D:\buildslave\clang-x64-ninja-win7\stage1\projects\compiler-rt\test\ubsan\Standalone-x86_64\TestCases\Float\Output\cast-overflow.cpp.tmp" "_"
Command 1 Result: 0
Command 1 Output:

Command 1 Stderr:

Command 2: "D:\buildslave\clang-x64-ninja-win7\stage1\projects\compiler-rt\test\ubsan\Standalone-x86_64\TestCases\Float\Output\cast-overflow.cpp.tmp" "0"
Command 2 Result: 0
Command 2 Output:

Command 2 Stderr:

Command 3: "FileCheck" "D:\buildslave\clang-x64-ninja-win7\llvm\projects\compiler-rt\test\ubsan\TestCases\Float\cast-overflow.cpp" "--check-prefix=CHECK-0"
Command 3 Result: 1
Command 3 Output:

Command 3 Stderr:
D:\buildslave\clang-x64-ninja-win7\llvm\projects\compiler-rt\test\ubsan\TestCases\Float\cast-overflow.cpp:89:14: error: expected string not found in input

// CHECK-0: {{.}}cast-overflow.cpp:[[@line+1]]:27: runtime error: value 2.14748{{.}} is outside the range of representable values of type 'int'

         ^

:1:1: note: scanning from here

D:\buildslave\clang-x64-ninja-win7\llvm\projects\compiler-rt\test\ubsan\TestCases\Float\cast-overflow.cpp:90:27: runtime error: value 0 is outside the range of representable values of type 'int'

^

:1:1: note: with expression "@line+1" equal to "90"

D:\buildslave\clang-x64-ninja-win7\llvm\projects\compiler-rt\test\ubsan\TestCases\Float\cast-overflow.cpp:90:27: runtime error: value 0 is outside the range of representable values of type 'int'

^

:1:85: note: possible intended match here

D:\buildslave\clang-x64-ninja-win7\llvm\projects\compiler-rt\test\ubsan\TestCases\Float\cast-overflow.cpp:90:27: runtime error: value 0 is outside the range of representable values of type 'int'

                                                                                ^
@nico
Copy link
Contributor Author

nico commented Mar 12, 2016

263111 kind of looks more likely, but they both don't look super likely :-/

@nico
Copy link
Contributor Author

nico commented Mar 12, 2016

Actually, it looks like the test only used to fail in non-bootstrap builds, and now after my XFAIL change the bot with "unexpectedly passed in bootstrap"

@nico
Copy link
Contributor Author

nico commented Mar 12, 2016

Actually, the first failing build is http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/10486 which makes more sense (263080, 263081)

@nico
Copy link
Contributor Author

nico commented Mar 12, 2016

Actually, it looks like the buildbot page doesn't list all revisions in that build. The previous build was at 263076, so 263077 263078 263079 might be it too.

@nico
Copy link
Contributor Author

nico commented Mar 12, 2016

Pretty sure it's r263077.

-#if defined(BIG_ENDIAN)
+#if BYTE_ORDER == ORDER_BIG_ENDIAN

This is now true if neither is defined, which is the case when building with MSVC.

@nico
Copy link
Contributor Author

nico commented Mar 12, 2016

Fixed in r263324.

Samsonov, please watch the tree a bit after landing changes.

@llvmbot
Copy link
Collaborator

llvmbot commented Mar 14, 2016

Nico, thank you for fixing this!

Sorry for not picking it up :(
I have received an email for http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/10486, but my changes in the blame list seemed completely irrelevant (they actually were, as r263077 was not listed there).

1 similar comment
@llvmbot
Copy link
Collaborator

llvmbot commented Mar 14, 2016

Nico, thank you for fixing this!

Sorry for not picking it up :(
I have received an email for http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/10486, but my changes in the blame list seemed completely irrelevant (they actually were, as r263077 was not listed there).

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 10, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bugzilla Issues migrated from bugzilla compiler-rt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nico @llvmbot