Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate conjunction or disjunction condition to reduce ISL Ast duplication #27933

Closed
llvmbot opened this issue Apr 28, 2016 · 2 comments
Closed

Generate conjunction or disjunction condition to reduce ISL Ast duplication #27933

llvmbot opened this issue Apr 28, 2016 · 2 comments
Labels
bugzilla Issues migrated from bugzilla polly

Comments

@llvmbot
Copy link
Collaborator

llvmbot commented Apr 28, 2016

Bugzilla Link 27559
Resolution FIXED
Resolved on Jun 11, 2016 23:31
Version unspecified
OS Windows NT
Reporter LLVM Bugzilla Contributor
CC @tobiasgrosser

Extended Description

The testcase is a unit test:
test/Isl/CodeGen/pointer-type-pointer-type-comparison.ll

produced Isl AST:

; CHECK: if (Q >= P + 1) {
; CHECK: for (int c0 = 0; c0 < N; c0 += 1)
; CHECK: Stmt_store(c0);
; CHECK: } else if (P >= Q + 1)
; CHECK: for (int c0 = 0; c0 < N; c0 += 1)
; CHECK: Stmt_store(c0);
; CHECK: }

In some cases the duplication is severe and it end up impacting compile-time and code size (LLVM optimization will not CSE the code).
@tobiasgrosser
Copy link
Contributor

The input schedule tree is rather simple:

domain: "[N, Q, P] -> { Stmt_store[i0] : 0 <= i0 < N and (P > Q or P < Q) }"
child:
schedule: "[N, Q, P] -> [{ Stmt_store[i0] -> [(i0)] }]"

@tobiasgrosser
Copy link
Contributor

Fixed in r272500.

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 10, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bugzilla Issues migrated from bugzilla polly
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tobiasgrosser @llvmbot