Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge r278268 into the 3.9 branch #30552

Closed
tstellar opened this issue Nov 29, 2016 · 5 comments
Closed

Merge r278268 into the 3.9 branch #30552

tstellar opened this issue Nov 29, 2016 · 5 comments
Assignees
Labels
bugzilla Issues migrated from bugzilla llvm:regalloc wontfix Issue is real, but we can't or won't fix it. Not invalid

Comments

@tstellar
Copy link
Collaborator

Bugzilla Link 31204
Resolution WONTFIX
Resolved on Dec 06, 2016 14:16
Version 3.9
OS Linux
Blocks #29609
CC @arsenm,@MatzeB

Extended Description

Hi Quentin,

Is this patch OK to merge to the 3.9 branch?

@tstellar
Copy link
Collaborator Author

assigned to @qcolombet

@qcolombet
Copy link
Collaborator

Adding Matthias who updated that part recently.

@MatzeB
Copy link
Contributor

MatzeB commented Dec 6, 2016

Hmm that commit seems questionable in its current form (I never got around looking at it when it went in). I proposed an update in the original review (https://reviews.llvm.org/D23303).

It's likely that we just don't hit problems in repairIntervalsInRange() because it is used very rarely.

@arsenm
Copy link
Contributor

arsenm commented Dec 6, 2016

Hmm that commit seems questionable in its current form (I never got around
looking at it when it went in). I proposed an update in the original review
(https://reviews.llvm.org/D23303).

It's likely that we just don't hit problems in repairIntervalsInRange()
because it is used very rarely.

The pass that hit this is now SSA and doesn't depend on LiveIntervals anymore, so it won't be able to hit this anymore

@tstellar
Copy link
Collaborator Author

tstellar commented Dec 6, 2016

Since we are already at -rc2, we'll skip merging this patch. It seems too risky.

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 10, 2021
@Quuxplusone Quuxplusone added the wontfix Issue is real, but we can't or won't fix it. Not invalid label Jan 20, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla Issues migrated from bugzilla llvm:regalloc wontfix Issue is real, but we can't or won't fix it. Not invalid
Projects
None yet
Development

No branches or pull requests

5 participants