Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry pick r294088 to 4.0 branch (MachineCopyPropagation fix) #31229

Closed
MatzeB opened this issue Feb 6, 2017 · 6 comments
Closed

Cherry pick r294088 to 4.0 branch (MachineCopyPropagation fix) #31229

MatzeB opened this issue Feb 6, 2017 · 6 comments
Assignees
@qcolombet
Labels
bugzilla Issues migrated from bugzilla llvm:codegen

Comments

@MatzeB
Copy link
Contributor

MatzeB commented Feb 6, 2017

Bugzilla Link 31881
Resolution FIXED
Resolved on Feb 08, 2017 10:43
Version trunk
OS All
Blocks #30970
Attachments Patch adapted to 4.0 branch
CC @zmodem

Extended Description

r294088 addresses a miscompile in situations with non-coalesced COPY instructions in combination with deeper register hierarchies (ARMv7 neon in this case). The problem was found in swift code but the issue is general.

The patch needs to be slightly adapted for the 4.0 branch, I attached a patch.
@MatzeB
Copy link
Contributor Author

MatzeB commented Feb 6, 2017

assigned to @qcolombet

@MatzeB
Copy link
Contributor Author

MatzeB commented Feb 6, 2017

To code owner for 4.0 branch review.

@zmodem
Copy link
Collaborator

zmodem commented Feb 7, 2017

To code owner for 4.0 branch review.

Did you mean to cc someone?

@MatzeB
Copy link
Contributor Author

MatzeB commented Feb 7, 2017

To code owner for 4.0 branch review.

Did you mean to cc someone?

I changed the "Assigned To:" field

@qcolombet
Copy link
Collaborator

SGTM.

@zmodem
Copy link
Collaborator

zmodem commented Feb 8, 2017

r294473.

@zmodem zmodem mentioned this issue Jan 13, 2017
Closed
@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 10, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qcolombet qcolombet

Labels
bugzilla Issues migrated from bugzilla llvm:codegen
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MatzeB @zmodem @qcolombet