Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge r292034 to 4.0.1 #31662

Closed
zmodem opened this issue Mar 16, 2017 · 3 comments
Closed

merge r292034 to 4.0.1 #31662

zmodem opened this issue Mar 16, 2017 · 3 comments
Assignees
@zmodem
Labels
bugzilla Issues migrated from bugzilla

Comments

@zmodem
Copy link
Collaborator

zmodem commented Mar 16, 2017

Bugzilla Link 32315
Resolution FIXED
Resolved on Apr 26, 2017 14:48
Version trunk
OS Linux
Depends On #31642
Blocks #31409
CC @tstellar

Extended Description

merge r292034 to 4.0.1
@zmodem
Copy link
Collaborator Author

zmodem commented Mar 16, 2017

assigned to @zmodem

@tstellar
Copy link
Collaborator

tstellar commented Apr 4, 2017

This looks like it will break the ABI. New 'const' versions of the functions need to be added instead of changing the existing functions (like what was done for the Iterator class).

Can you attach an updated patch?

@zmodem
Copy link
Collaborator Author

zmodem commented Apr 26, 2017

I tweaked it to not remove the old functions and merged in r301479.

@jsonn jsonn mentioned this issue Feb 24, 2017
Closed
@llvmbot llvmbot mentioned this issue Mar 16, 2017
Closed
@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 10, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zmodem zmodem

Labels
bugzilla Issues migrated from bugzilla
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tstellar @zmodem