Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hexagon] crash: CANNOT select: t16: v32i1 = HexagonISD::QFALSE #35668

Closed
rotateright opened this issue Feb 9, 2018 · 3 comments
Closed

[Hexagon] crash: CANNOT select: t16: v32i1 = HexagonISD::QFALSE #35668

rotateright opened this issue Feb 9, 2018 · 3 comments
Labels
backend:Hexagon bugzilla Issues migrated from bugzilla

Comments

@rotateright
Copy link
Contributor

Bugzilla Link 36320
Resolution FIXED
Resolved on Feb 09, 2018 11:13
Version trunk
OS All
CC @kparzysz-quic

Extended Description

The following is a slight modification of an existing Hexagon regression test at:
test/CodeGen/Hexagon/autohvx/isel-setcc-pair.ll

The only difference is that I have replaced an 'undef' operand of the vector 'and' instruction with a zero operand.

As noted in bug 36305, our handling of undef operands in the DAG is wrong. In this particular case, I think the difference is caused because currently in the DAG for vectors we have:
and x, undef --> undef

But this is wrong. It should be:
and x, undef --> 0


; RUN: llc -march=hexagon < %s | FileCheck %s

; Check that a setcc of a vector pair is handled (without crashing).
; CHECK: vcmp

target datalayout = "e-m:e-p:32:32:32-a:0-n16:32-i64:64:64-i32:32:32-i16:16:16-i1:8:8-f32:32:32-f64:64:64-v32:32:32-v64:64:64-v512:512:512-v1024:1024:1024-v2048:2048:2048"
target triple = "hexagon"

; Function Attrs: nounwind
define hidden fastcc void @​fred(i32 %a0) #​0 {
b1:
%v2 = insertelement <32 x i32> undef, i32 %a0, i32 0
%v3 = shufflevector <32 x i32> %v2, <32 x i32> undef, <32 x i32> zeroinitializer
%v4 = icmp eq <32 x i32> %v3, undef
%v5 = and <32 x i1> zeroinitializer, %v4
br label %b6

b6: ; preds = %b1
%v7 = extractelement <32 x i1> %v5, i32 22
br i1 %v7, label %b8, label %b9

b8: ; preds = %b6
unreachable

b9: ; preds = %b6
unreachable
}

attributes #​0 = { nounwind "target-cpu"="hexagonv60" "target-features"="+hvx,+hvx-length64b" }

@rotateright
Copy link
Contributor Author

Note: I have no idea if this is a legitimate test for Hexagon, but the crash is blocking a potential fix for bug 36305 that I was testing.

@kparzysz-quic
Copy link

Fixed in r324763.

@rotateright
Copy link
Contributor Author

Fixed in r324763.

Wow...thanks for the fast fix!

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 10, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend:Hexagon bugzilla Issues migrated from bugzilla
Projects
None yet
Development

No branches or pull requests

2 participants