Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect checking of the f2c / f95 library directory #1248

Closed
llvmbot opened this issue Aug 10, 2006 · 7 comments
Closed

incorrect checking of the f2c / f95 library directory #1248

llvmbot opened this issue Aug 10, 2006 · 7 comments
Labels
bugzilla Issues migrated from bugzilla build-problem test-suite

Comments

@llvmbot
Copy link
Collaborator

llvmbot commented Aug 10, 2006

Bugzilla Link 876
Resolution FIXED
Resolved on Feb 22, 2010 12:49
Version 1.8
OS Linux
Reporter LLVM Bugzilla Contributor

Extended Description

In the configure file of llvm-test, libvar is used instead of libval, which
causes an incorrect error when specifying the F2C or F95 library directory using
--with-f2c-lib or --with-f95-lib.
Solution:

replace

eval libvar=${f95libdir}

with

eval libval=${f95libdir}

Idem for f2c:

eval libvar=${f2clibdir} -> eval libval=${f2clibdir}

Along with this, after checking if the specified directories are in fact
directories, the variable USE_F2C is set to 1, which is incorrect.

USE_F2C=1 should be replaced with USE_F2C="USE_F2C=1"

Same for USE_F95.

@lattner
Copy link
Collaborator

lattner commented Aug 14, 2006

Reid, any thoughts on this bug?

@llvmbot
Copy link
Collaborator Author

llvmbot commented Aug 15, 2006

Sounds straight forward enough. I have no way to test this, however.
I can make the changes if someone with f2c/f95 can do the testing.

@llvmbot
Copy link
Collaborator Author

llvmbot commented Aug 15, 2006

Mine

@llvmbot
Copy link
Collaborator Author

llvmbot commented Aug 15, 2006

Fixed.

Both problems are actually in LLVM, not llvm-test, so make sure to update the
llvm autoconf directory to get the new version of find_std_program.m4 and the
configure script.

These are the patches:

http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20060814/036736.html
http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20060814/036737.html
http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20060814/036738.html

Thanks for pointing these out!

Reid.

@llvmbot
Copy link
Collaborator Author

llvmbot commented Aug 15, 2006

Kenneth,

One thing. Could you please obtain the changes I've committed and test them out?
I don't have f95/f2c here so I made the changes without testing them. They seem
pretty straight forward so I don't expect problems. However, it would be nice if
you could try it and then mark this bug "VERIFIED" if it works for you. If it
doesn't, please reopen it and indicate what went wrong.

Thanks for your help!

Reid.

@llvmbot
Copy link
Collaborator Author

llvmbot commented Aug 15, 2006

I can only test this at work, i.e. in one of the upcoming days... I'm not sure
how to obtain the changes you've comitted though, I'm fairly new to all this...

@llvmbot
Copy link
Collaborator Author

llvmbot commented Aug 15, 2006

Kenneth,

To test these changes you need to be working from the CVS version of LLVM. I
suggest you read the http://llvm.org/docs/GettingStarted.html document to learn
how to do that. If you're already working from CVS, the simply do:

cd /path/to/llvm/
cvs update
cd /path/to/llvm/projects/llvm-test
cvs update

If you can't use CVS for some reason, then you can review all the recent patches
I made in those directories and apply them yourself to your local copy. You can
find the patches here:

http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20060814/date.html

In addition to the ones I identified above, you also need these late breaking
patches:

http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20060814/036754.html
http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20060814/036755.html
http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20060814/036756.html
http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20060814/036757.html
http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20060814/036758.html

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 3, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla Issues migrated from bugzilla build-problem test-suite
Projects
None yet
Development

No branches or pull requests

2 participants