This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Guard testing implementation details.
ClosedPublic

Authored by Mordante on Jul 7 2021, 11:25 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rG4947ecf4e994: [libc++] Guard testing implementation details.
Summary

The unit tests test some implementation details. As @Quuxplusone pointed
out in D96664 this should only be tested when the tests use libc++. This
addresses the issue for code already in main.

Diff Detail

Event Timeline

Mordante requested review of this revision.Jul 7 2021, 11:25 AM
Mordante created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJul 7 2021, 11:25 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.Jul 7 2021, 1:23 PM
ldionne added a subscriber: ldionne.

LGTM, but it would be more consistent to replace both with LIBCPP_ASSERT.

libcxx/test/std/utilities/format/format.formatter/format.parse.ctx/check_arg_id.pass.cpp
43

We have LIBCPP_ASSERT.

This revision is now accepted and ready to land.Jul 7 2021, 1:23 PM
Mordante updated this revision to Diff 357133.Jul 7 2021, 10:22 PM

Addresses review comments.

Mordante marked an inline comment as done.Jul 7 2021, 10:23 PM

Thanks for the review! I updated the patch and will land it after the CI passes.

This revision was automatically updated to reflect the committed changes.