This is an archive of the discontinued LLVM Phabricator instance.

Differential D132479

[runtimes] Shrink the set of runtimes included in the bootstrapping build by default
ClosedPublic

Authored by ldionne on Aug 23 2022, 8:35 AM.

Details

Reviewers
phosek
jdoerfert
Ericson2314
Commits
rGc084b1486664: [runtimes] Shrink the set of runtimes included in the bootstrapping build by…
Summary

This patch is in preparation for removing libcxx, libcxxabi and libunwind
from LLVM_ENABLE_PROJECTS. When we make that switch, folks who were
previously using LLVM_ENABLE_PROJECTS=all in order to build those
runtimes will be able to add LLVM_ENABLE_RUNTIMES=all to start building
those projects using the bootstrapping build.

This is technically a breaking change for folks who had been using
LLVM_ENABLE_RUNTIMES=all, however I suspect the set of people currently
doing that is extremely small, so this is likely acceptable (more than
breaking folks who are using LLVM_ENABLE_PROJECTS=all).

Diff Detail

Event Timeline

ldionne created this revision.Aug 23 2022, 8:35 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 23 2022, 8:35 AM
Herald added a subscriber: mgorny. · View Herald Transcript
ldionne requested review of this revision.Aug 23 2022, 8:35 AM
Herald added a reviewer: jdoerfert. · View Herald TranscriptAug 23 2022, 8:35 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, sstefan1. · View Herald Transcript
Harbormaster completed remote builds in B182857: Diff 454852.Aug 23 2022, 8:36 AM
ldionne added a parent revision: D132478: [runtimes][NFC] Colocate handling of LLVM_ENABLE_PROJECTS and LLVM_ENABLE_RUNTIMES.Aug 23 2022, 8:37 AM
ldionne added a child revision: D132480: [llvm] Remove libcxx, libcxxabi and libunwind from supported LLVM_ENABLE_PROJECTS.
ldionne mentioned this in D132324: [RFC] Remove support for building libc++ with `LLVM_ENABLE_PROJECTS`.Aug 23 2022, 8:41 AM
Ericson2314 accepted this revision.Aug 23 2022, 1:45 PM
This revision is now accepted and ready to land.Aug 23 2022, 1:45 PM
phosek accepted this revision.Aug 23 2022, 11:39 PM

LGTM

ldionne updated this revision to Diff 455225.Aug 24 2022, 8:12 AM

Rebase onto main.

Harbormaster completed remote builds in B183119: Diff 455225.Aug 24 2022, 9:20 AM
This revision was landed with ongoing or failed builds.Aug 31 2022, 6:42 PM
Closed by commit rGc084b1486664: [runtimes] Shrink the set of runtimes included in the bootstrapping build by… (authored by ldionne). · Explain Why
This revision was automatically updated to reflect the committed changes.
ldionne added a commit: rGc084b1486664: [runtimes] Shrink the set of runtimes included in the bootstrapping build by….

Revision Contents

PathSize
llvm/
5 lines

Diff 457150

llvm/CMakeLists.txt

Show First 20 Lines • Show All 138 Lines • ▼ Show 20 Linesif ("flang" IN_LIST LLVM_ENABLE_PROJECTS)
endif() endif()
if (NOT "clang" IN_LIST LLVM_ENABLE_PROJECTS) if (NOT "clang" IN_LIST LLVM_ENABLE_PROJECTS)
message(FATAL_ERROR "Clang is not enabled, but is required for the Flang driver") message(FATAL_ERROR "Clang is not enabled, but is required for the Flang driver")
endif() endif()
endif() endif()
# Select the runtimes to build # Select the runtimes to build
set(LLVM_DEFAULT_RUNTIMES "compiler-rt;libc;libcxx;libcxxabi;libunwind;openmp") #
# As we migrate runtimes to using the bootstrapping build, the set of default runtimes
# should grow as we remove those runtimes from LLVM_ENABLE_PROJECTS above.
set(LLVM_DEFAULT_RUNTIMES "libcxx;libcxxabi;libunwind")
set(LLVM_SUPPORTED_RUNTIMES "libc;libunwind;libcxxabi;pstl;libcxx;compiler-rt;openmp;llvm-libgcc") set(LLVM_SUPPORTED_RUNTIMES "libc;libunwind;libcxxabi;pstl;libcxx;compiler-rt;openmp;llvm-libgcc")
set(LLVM_ENABLE_RUNTIMES "" CACHE STRING set(LLVM_ENABLE_RUNTIMES "" CACHE STRING
"Semicolon-separated list of runtimes to build, or \"all\" (${LLVM_DEFAULT_RUNTIMES}). Supported runtimes are ${LLVM_SUPPORTED_RUNTIMES}.") "Semicolon-separated list of runtimes to build, or \"all\" (${LLVM_DEFAULT_RUNTIMES}). Supported runtimes are ${LLVM_SUPPORTED_RUNTIMES}.")
if(LLVM_ENABLE_RUNTIMES STREQUAL "all") if(LLVM_ENABLE_RUNTIMES STREQUAL "all")
set(LLVM_ENABLE_RUNTIMES ${LLVM_DEFAULT_RUNTIMES}) set(LLVM_ENABLE_RUNTIMES ${LLVM_DEFAULT_RUNTIMES})
endif() endif()
foreach(proj IN LISTS LLVM_ENABLE_RUNTIMES) foreach(proj IN LISTS LLVM_ENABLE_RUNTIMES)
if (NOT "${proj}" IN_LIST LLVM_SUPPORTED_RUNTIMES) if (NOT "${proj}" IN_LIST LLVM_SUPPORTED_RUNTIMES)
▲ Show 20 Lines • Show All 1,198 Lines • Show Last 20 Lines