This is an archive of the discontinued LLVM Phabricator instance.

Differential D147065

[libc++] Fix CI on release/16.x
ClosedPublic

Authored by ldionne on Mar 28 2023, 10:12 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Summary

This patch is aimed directly at release/16.x -- it ensures that we
can run the CI successfully on the release branch.

Diff Detail

Unit TestsFailed

TimeTest
1,500,290 mslibcxx CI AIX (32-bit) > ibm-libc++-shared-cfg-in.std/algorithms/alg_modifying_operations/alg_transform::ranges.transform.binary.pass.cpp
1,500,030 mslibcxx CI Apple back-deployment macosx11.0 arm64 > apple-libc++-backdeployment-cfg-in.std/thread/thread_condition::notify_all_at_thread_exit_lwg3343.pass.cpp
1,500,060 mslibcxx CI Apple back-deployment with assertions enabled > apple-libc++-backdeployment-cfg-in.std/thread/thread_condition::notify_all_at_thread_exit_lwg3343.pass.cpp

Event Timeline

ldionne created this revision.Mar 28 2023, 10:12 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 28 2023, 10:12 AM
Herald added a subscriber: arichardson. · View Herald Transcript
ldionne requested review of this revision.Mar 28 2023, 10:12 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 28 2023, 10:12 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
ldionne updated this revision to Diff 509115.Mar 28 2023, 1:31 PM

Fix some tests with experimental features disabled.

ldionne added a child revision: D146421: [release/16.x][libc++] Revert the bitset sort optimization.Mar 28 2023, 3:12 PM
ldionne mentioned this in D146421: [release/16.x][libc++] Revert the bitset sort optimization.Mar 28 2023, 3:13 PM
Harbormaster completed remote builds in B222330: Diff 509115.Mar 28 2023, 11:25 PM
ldionne added a comment.Mar 29 2023, 2:19 PM

Merging to release/16.x in https://github.com/llvm/llvm-project/issues/61792.

ldionne accepted this revision.Apr 19 2023, 8:06 AM
This revision is now accepted and ready to land.Apr 19 2023, 8:06 AM
ldionne closed this revision.Apr 19 2023, 8:07 AM

Closing since this has been merged.

Revision Contents

Diff 509115

libcxx/test/libcxx/assertions/headers_declare_verbose_abort.sh.cpp

Show First 20 Lines • Show All 657 Lines • ▼ Show 20 Lines
// RUN: %{build} -DTEST_122 // RUN: %{build} -DTEST_122
#if defined(TEST_122) && __cplusplus >= 201103L #if defined(TEST_122) && __cplusplus >= 201103L
# include <experimental/algorithm> # include <experimental/algorithm>
using HandlerType = decltype(std::__libcpp_verbose_abort); using HandlerType = decltype(std::__libcpp_verbose_abort);
#endif #endif
// RUN: %{build} -DTEST_123 // RUN: %{build} -DTEST_123
#if defined(TEST_123) && __cplusplus >= 201103L && !defined(_LIBCPP_HAS_NO_EXPERIMENTAL_COROUTINES) #if defined(TEST_123) && __cplusplus >= 202002L && !defined(_LIBCPP_HAS_NO_EXPERIMENTAL_COROUTINES)
# include <experimental/coroutine> # include <experimental/coroutine>
using HandlerType = decltype(std::__libcpp_verbose_abort); using HandlerType = decltype(std::__libcpp_verbose_abort);
#endif #endif
// RUN: %{build} -DTEST_124 // RUN: %{build} -DTEST_124
#if defined(TEST_124) && __cplusplus >= 201103L #if defined(TEST_124) && __cplusplus >= 201103L
# include <experimental/deque> # include <experimental/deque>
using HandlerType = decltype(std::__libcpp_verbose_abort); using HandlerType = decltype(std::__libcpp_verbose_abort);
▲ Show 20 Lines • Show All 111 Lines • Show Last 20 Lines

libcxx/test/libcxx/clang_tidy.sh.cpp

Show First 20 Lines • Show All 211 Lines • ▼ Show 20 Lines
# include <wchar.h> # include <wchar.h>
#endif #endif
#if !defined(_LIBCPP_HAS_NO_WIDE_CHARACTERS) #if !defined(_LIBCPP_HAS_NO_WIDE_CHARACTERS)
# include <wctype.h> # include <wctype.h>
#endif #endif
#if __cplusplus >= 201103L #if __cplusplus >= 201103L
# include <experimental/algorithm> # include <experimental/algorithm>
#endif #endif
#if __cplusplus >= 201103L && !defined(_LIBCPP_HAS_NO_EXPERIMENTAL_COROUTINES) #if __cplusplus >= 202002L && !defined(_LIBCPP_HAS_NO_EXPERIMENTAL_COROUTINES)
# include <experimental/coroutine> # include <experimental/coroutine>
#endif #endif
#if __cplusplus >= 201103L #if __cplusplus >= 201103L
# include <experimental/deque> # include <experimental/deque>
#endif #endif
#if __cplusplus >= 201103L #if __cplusplus >= 201103L
# include <experimental/forward_list> # include <experimental/forward_list>
#endif #endif
▲ Show 20 Lines • Show All 48 Lines • Show Last 20 Lines

libcxx/test/libcxx/double_include.sh.cpp

Show First 20 Lines • Show All 212 Lines • ▼ Show 20 Lines
# include <wchar.h> # include <wchar.h>
#endif #endif
#if !defined(_LIBCPP_HAS_NO_WIDE_CHARACTERS) #if !defined(_LIBCPP_HAS_NO_WIDE_CHARACTERS)
# include <wctype.h> # include <wctype.h>
#endif #endif
#if __cplusplus >= 201103L #if __cplusplus >= 201103L
# include <experimental/algorithm> # include <experimental/algorithm>
#endif #endif
#if __cplusplus >= 201103L && !defined(_LIBCPP_HAS_NO_EXPERIMENTAL_COROUTINES) #if __cplusplus >= 202002L && !defined(_LIBCPP_HAS_NO_EXPERIMENTAL_COROUTINES)
# include <experimental/coroutine> # include <experimental/coroutine>
#endif #endif
#if __cplusplus >= 201103L #if __cplusplus >= 201103L
# include <experimental/deque> # include <experimental/deque>
#endif #endif
#if __cplusplus >= 201103L #if __cplusplus >= 201103L
# include <experimental/forward_list> # include <experimental/forward_list>
#endif #endif
▲ Show 20 Lines • Show All 52 Lines • Show Last 20 Lines

libcxx/test/libcxx/min_max_macros.compile.pass.cpp

Show First 20 Lines • Show All 335 Lines • ▼ Show 20 Lines
#if !defined(_LIBCPP_HAS_NO_WIDE_CHARACTERS) #if !defined(_LIBCPP_HAS_NO_WIDE_CHARACTERS)
# include <wctype.h> # include <wctype.h>
TEST_MACROS(); TEST_MACROS();
#endif #endif
#if __cplusplus >= 201103L #if __cplusplus >= 201103L
# include <experimental/algorithm> # include <experimental/algorithm>
TEST_MACROS(); TEST_MACROS();
#endif #endif
#if __cplusplus >= 201103L && !defined(_LIBCPP_HAS_NO_EXPERIMENTAL_COROUTINES) #if __cplusplus >= 202002L && !defined(_LIBCPP_HAS_NO_EXPERIMENTAL_COROUTINES)
# include <experimental/coroutine> # include <experimental/coroutine>
TEST_MACROS(); TEST_MACROS();
#endif #endif
#if __cplusplus >= 201103L #if __cplusplus >= 201103L
# include <experimental/deque> # include <experimental/deque>
TEST_MACROS(); TEST_MACROS();
#endif #endif
#if __cplusplus >= 201103L #if __cplusplus >= 201103L
▲ Show 20 Lines • Show All 68 Lines • Show Last 20 Lines

libcxx/test/libcxx/modules_include.sh.cpp

Show First 20 Lines • Show All 538 Lines • ▼ Show 20 Lines
#if defined(TEST_121) && !defined(_LIBCPP_HAS_NO_WIDE_CHARACTERS) #if defined(TEST_121) && !defined(_LIBCPP_HAS_NO_WIDE_CHARACTERS)
#include <wctype.h> #include <wctype.h>
#endif #endif
// RUN: %{cxx} %s %{flags} %{compile_flags} -fmodules -fcxx-modules -fmodules-cache-path=%t -fsyntax-only -DTEST_122 // RUN: %{cxx} %s %{flags} %{compile_flags} -fmodules -fcxx-modules -fmodules-cache-path=%t -fsyntax-only -DTEST_122
#if defined(TEST_122) && __cplusplus >= 201103L #if defined(TEST_122) && __cplusplus >= 201103L
#include <experimental/algorithm> #include <experimental/algorithm>
#endif #endif
// RUN: %{cxx} %s %{flags} %{compile_flags} -fmodules -fcxx-modules -fmodules-cache-path=%t -fsyntax-only -DTEST_123 // RUN: %{cxx} %s %{flags} %{compile_flags} -fmodules -fcxx-modules -fmodules-cache-path=%t -fsyntax-only -DTEST_123
#if defined(TEST_123) && __cplusplus >= 201103L && !defined(_LIBCPP_HAS_NO_EXPERIMENTAL_COROUTINES) #if defined(TEST_123) && __cplusplus >= 202002L && !defined(_LIBCPP_HAS_NO_EXPERIMENTAL_COROUTINES)
#include <experimental/coroutine> #include <experimental/coroutine>
#endif #endif
// RUN: %{cxx} %s %{flags} %{compile_flags} -fmodules -fcxx-modules -fmodules-cache-path=%t -fsyntax-only -DTEST_124 // RUN: %{cxx} %s %{flags} %{compile_flags} -fmodules -fcxx-modules -fmodules-cache-path=%t -fsyntax-only -DTEST_124
#if defined(TEST_124) && __cplusplus >= 201103L #if defined(TEST_124) && __cplusplus >= 201103L
#include <experimental/deque> #include <experimental/deque>
#endif #endif
// RUN: %{cxx} %s %{flags} %{compile_flags} -fmodules -fcxx-modules -fmodules-cache-path=%t -fsyntax-only -DTEST_125 // RUN: %{cxx} %s %{flags} %{compile_flags} -fmodules -fcxx-modules -fmodules-cache-path=%t -fsyntax-only -DTEST_125
#if defined(TEST_125) && __cplusplus >= 201103L #if defined(TEST_125) && __cplusplus >= 201103L
▲ Show 20 Lines • Show All 71 Lines • Show Last 20 Lines

libcxx/test/libcxx/nasty_macros.compile.pass.cpp

Show First 20 Lines • Show All 336 Lines • ▼ Show 20 Lines
# include <wchar.h> # include <wchar.h>
#endif #endif
#if !defined(_LIBCPP_HAS_NO_WIDE_CHARACTERS) #if !defined(_LIBCPP_HAS_NO_WIDE_CHARACTERS)
# include <wctype.h> # include <wctype.h>
#endif #endif
#if __cplusplus >= 201103L #if __cplusplus >= 201103L
# include <experimental/algorithm> # include <experimental/algorithm>
#endif #endif
#if __cplusplus >= 201103L && !defined(_LIBCPP_HAS_NO_EXPERIMENTAL_COROUTINES) #if __cplusplus >= 202002L && !defined(_LIBCPP_HAS_NO_EXPERIMENTAL_COROUTINES)
# include <experimental/coroutine> # include <experimental/coroutine>
#endif #endif
#if __cplusplus >= 201103L #if __cplusplus >= 201103L
# include <experimental/deque> # include <experimental/deque>
#endif #endif
#if __cplusplus >= 201103L #if __cplusplus >= 201103L
# include <experimental/forward_list> # include <experimental/forward_list>
#endif #endif
▲ Show 20 Lines • Show All 48 Lines • Show Last 20 Lines

libcxx/test/libcxx/no_assert_include.compile.pass.cpp

Show First 20 Lines • Show All 209 Lines • ▼ Show 20 Lines
# include <wchar.h> # include <wchar.h>
#endif #endif
#if !defined(_LIBCPP_HAS_NO_WIDE_CHARACTERS) #if !defined(_LIBCPP_HAS_NO_WIDE_CHARACTERS)
# include <wctype.h> # include <wctype.h>
#endif #endif
#if __cplusplus >= 201103L #if __cplusplus >= 201103L
# include <experimental/algorithm> # include <experimental/algorithm>
#endif #endif
#if __cplusplus >= 201103L && !defined(_LIBCPP_HAS_NO_EXPERIMENTAL_COROUTINES) #if __cplusplus >= 202002L && !defined(_LIBCPP_HAS_NO_EXPERIMENTAL_COROUTINES)
# include <experimental/coroutine> # include <experimental/coroutine>
#endif #endif
#if __cplusplus >= 201103L #if __cplusplus >= 201103L
# include <experimental/deque> # include <experimental/deque>
#endif #endif
#if __cplusplus >= 201103L #if __cplusplus >= 201103L
# include <experimental/forward_list> # include <experimental/forward_list>
#endif #endif
▲ Show 20 Lines • Show All 52 Lines • Show Last 20 Lines

libcxx/test/libcxx/ranges/range.adaptors/range.join/segmented_iterator.compile.pass.cpp

//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// UNSUPPORTED: c++03, c++11, c++14, c++17 // UNSUPPORTED: c++03, c++11, c++14, c++17
// UNSUPPORTED: !c++experimental
#include <ranges> #include <ranges>
#include <utility>
#include <vector> #include <vector>
using JoinView = decltype(std::views::join(std::declval<std::vector<std::vector<int>>&>())); using JoinView = decltype(std::views::join(std::declval<std::vector<std::vector<int>>&>()));
using JoinIter = std::ranges::iterator_t<JoinView>; using JoinIter = std::ranges::iterator_t<JoinView>;
static_assert(std::__is_segmented_iterator<JoinIter>::value); static_assert(std::__is_segmented_iterator<JoinIter>::value);

libcxx/test/std/ranges/iterator_robust_against_adl.compile.pass.cpp

//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// UNSUPPORTED: c++03, c++11, c++14, c++17 // UNSUPPORTED: c++03, c++11, c++14, c++17
// UNSUPPORTED: !c++experimental
// ADL call with nested iterators of views should not look up base's view's // ADL call with nested iterators of views should not look up base's view's
// namespace // namespace
#include <ranges> #include <ranges>
#include <tuple> #include <tuple>
#include "test_macros.h" #include "test_macros.h"
▲ Show 20 Lines • Show All 61 Lines • Show Last 20 Lines

libcxx/utils/ci/buildkite-pipeline.yml

Show All 30 Linessteps:
# Light pre-commit tests for things like formatting or when people forget # Light pre-commit tests for things like formatting or when people forget
# to update generated files. # to update generated files.
# #
- label: "Format" - label: "Format"
command: "libcxx/utils/ci/run-buildbot check-format" command: "libcxx/utils/ci/run-buildbot check-format"
artifact_paths: artifact_paths:
- "**/clang-format.patch" - "**/clang-format.patch"
env: env:
GIT_CLANG_FORMAT: "/usr/bin/git-clang-format-${LLVM_STABLE_VERSION}" GIT_CLANG_FORMAT: "/usr/bin/git-clang-format-${LLVM_STABLE_VERSION} --binary clang-format-${LLVM_STABLE_VERSION}"
CC: "clang-${LLVM_HEAD_VERSION}"
CXX: "clang++-${LLVM_HEAD_VERSION}"
agents: agents:
queue: "libcxx-builders" queue: "libcxx-builders"
os: "linux" os: "linux"
retry: retry:
automatic: automatic:
- exit_status: -1 # Agent was lost - exit_status: -1 # Agent was lost
limit: 2 limit: 2
soft_fail: soft_fail:
- exit_status: 1 - exit_status: 1
timeout_in_minutes: 120 timeout_in_minutes: 120
- label: "Generated output" - label: "Generated output"
command: "libcxx/utils/ci/run-buildbot check-generated-output" command: "libcxx/utils/ci/run-buildbot check-generated-output"
env:
CC: "clang-${LLVM_HEAD_VERSION}"
CXX: "clang++-${LLVM_HEAD_VERSION}"
artifact_paths: artifact_paths:
- "**/generated_output.patch" - "**/generated_output.patch"
- "**/generated_output.status" - "**/generated_output.status"
agents: agents:
queue: "libcxx-builders" queue: "libcxx-builders"
os: "linux" os: "linux"
retry: retry:
automatic: automatic:
- exit_status: -1 # Agent was lost - exit_status: -1 # Agent was lost
limit: 2 limit: 2
timeout_in_minutes: 120 timeout_in_minutes: 120
- label: "Documentation" - label: "Documentation"
command: "libcxx/utils/ci/run-buildbot documentation" command: "libcxx/utils/ci/run-buildbot documentation"
env:
CC: "clang-${LLVM_HEAD_VERSION}"
CXX: "clang++-${LLVM_HEAD_VERSION}"
artifact_paths: artifact_paths:
- "**/test-results.xml" - "**/test-results.xml"
agents: agents:
queue: "libcxx-builders" queue: "libcxx-builders"
os: "linux" os: "linux"
retry: retry:
automatic: automatic:
- exit_status: -1 # Agent was lost - exit_status: -1 # Agent was lost
▲ Show 20 Lines • Show All 888 Lines • Show Last 20 Lines

libcxx/utils/generate_header_tests.py

Show All 37 Linesheader_restrictions = {
"strstream": "!defined(_LIBCPP_HAS_NO_LOCALIZATION)", "strstream": "!defined(_LIBCPP_HAS_NO_LOCALIZATION)",
"wctype.h": "!defined(_LIBCPP_HAS_NO_WIDE_CHARACTERS)", "wctype.h": "!defined(_LIBCPP_HAS_NO_WIDE_CHARACTERS)",
"cwctype": "!defined(_LIBCPP_HAS_NO_WIDE_CHARACTERS)", "cwctype": "!defined(_LIBCPP_HAS_NO_WIDE_CHARACTERS)",
"cwchar": "!defined(_LIBCPP_HAS_NO_WIDE_CHARACTERS)", "cwchar": "!defined(_LIBCPP_HAS_NO_WIDE_CHARACTERS)",
"wchar.h": "!defined(_LIBCPP_HAS_NO_WIDE_CHARACTERS)", "wchar.h": "!defined(_LIBCPP_HAS_NO_WIDE_CHARACTERS)",
"experimental/algorithm": "__cplusplus >= 201103L", "experimental/algorithm": "__cplusplus >= 201103L",
"experimental/coroutine": "__cplusplus >= 201103L && !defined(_LIBCPP_HAS_NO_EXPERIMENTAL_COROUTINES)", "experimental/coroutine": "__cplusplus >= 202002L && !defined(_LIBCPP_HAS_NO_EXPERIMENTAL_COROUTINES)",
"experimental/deque": "__cplusplus >= 201103L", "experimental/deque": "__cplusplus >= 201103L",
"experimental/forward_list": "__cplusplus >= 201103L", "experimental/forward_list": "__cplusplus >= 201103L",
"experimental/functional": "__cplusplus >= 201103L", "experimental/functional": "__cplusplus >= 201103L",
"experimental/iterator": "__cplusplus >= 201103L", "experimental/iterator": "__cplusplus >= 201103L",
"experimental/list": "__cplusplus >= 201103L", "experimental/list": "__cplusplus >= 201103L",
"experimental/map": "__cplusplus >= 201103L", "experimental/map": "__cplusplus >= 201103L",
"experimental/memory_resource": "__cplusplus >= 201103L", "experimental/memory_resource": "__cplusplus >= 201103L",
"experimental/propagate_const": "__cplusplus >= 201103L", "experimental/propagate_const": "__cplusplus >= 201103L",
▲ Show 20 Lines • Show All 101 Lines • Show Last 20 Lines