Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

__cpp_lib_make_unique not defined in <memory> #38192

Closed
apolukhin opened this issue Sep 5, 2018 · 4 comments
Closed

__cpp_lib_make_unique not defined in <memory> #38192

apolukhin opened this issue Sep 5, 2018 · 4 comments
Assignees
@mclow
Labels
bugzilla Issues migrated from bugzilla libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.

Comments

@apolukhin
Copy link
Member

Bugzilla Link 38844
Resolution FIXED
Resolved on Feb 07, 2019 09:35
Version 7.0
OS Linux
CC @apolukhin,@dwblaikie,@mclow

Extended Description

Multiple projects suffer from that (see https://reviews.freebsd.org/rP460135 as an example).

Please add the following line

#define __cpp_lib_make_unique 201304

near make_unique definition.
@apolukhin
Copy link
Member Author

assigned to @mclow

@mclow
Copy link
Contributor

mclow commented Sep 5, 2018

Currently, libc++ does not define any feature macros.

These were not required, but rather were advisory.
This will be changing for C++20 (see https://wg21.link/P0941)

@mclow
Copy link
Contributor

mclow commented Sep 5, 2018

Currently, libc++ does not define any feature macros.

Ok, I was wrong. We define a couple.
Someone must have snuck them in when I wasn't paying close enough attention.

@mclow
Copy link
Contributor

mclow commented Feb 7, 2019

This has been fixed.

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 10, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mclow mclow

Labels
bugzilla Issues migrated from bugzilla libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mclow @apolukhin