Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RuntimeDyldMachOARM.h - comparison is always true due to limited range of data type #41381

Closed
RKSimon opened this issue May 27, 2019 · 2 comments
Closed

RuntimeDyldMachOARM.h - comparison is always true due to limited range of data type #41381

RKSimon opened this issue May 27, 2019 · 2 comments
Labels
bugzilla Issues migrated from bugzilla

Comments

@RKSimon
Copy link
Collaborator

RKSimon commented May 27, 2019

Bugzilla Link 42036
Resolution FIXED
Resolved on Sep 06, 2019 10:26
Version trunk
OS Windows NT
CC @AlexDenisov,@lhames,@sanjoy

Extended Description

http://lab.llvm.org:8011/builders/clang-cmake-aarch64-full/builds/7242/steps/build%20stage%201/logs/warnings%20%281%29

  uint16_t LowInsn = readBytesUnaligned(LocalAddress + 2, 2);
  assert((LowInsn & 0xf800) != 0xf8000 &&
         "Unrecognized thumb branch encoding (BR22 low bits)");

This warning suggests a typo in the assertion - should it be:

  assert((LowInsn & 0xf800) != 0xf800 &&
         "Unrecognized thumb branch encoding (BR22 low bits)");
@lhames
Copy link
Contributor

lhames commented May 27, 2019

Thanks Simon -- nice catch!

Fixed in r361782.

@RKSimon
Copy link
Collaborator Author

RKSimon commented Sep 6, 2019

*** Bug #36543 has been marked as a duplicate of this bug. ***

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 10, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bugzilla Issues migrated from bugzilla
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lhames @RKSimon