Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test\CodeGenCXX\debug-info-gline-tables-only-codeview.cpp fails on 32-bit windows #48264

Closed
zmodem opened this issue Jan 28, 2021 · 4 comments
Closed
Labels
bugzilla Issues migrated from bugzilla clang Clang issues not falling into any other category

Comments

@zmodem
Copy link
Collaborator

zmodem commented Jan 28, 2021

Bugzilla Link 48920
Resolution FIXED
Resolved on Jan 29, 2021 22:22
Version trunk
OS Linux
Blocks #48246
CC @amykhuang,@zygoloid,@tstellar
Fixed by commit(s) 0024efc 99f43f5

Extended Description

in a VS 2019 x86 Native Tools Command Prompt

with llvmorg-12.0.0-rc1 checked out

cmake -GNinja -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_ASSERTIONS=ON -DLLVM_ENABLE_PROJECTS="clang;openmp" ..\llvm
ninja check-clang

-- Testing: 27111 tests, 32 workers --
Testing: 0.. 10.
FAIL: Clang :: CodeGenCXX/debug-info-gline-tables-only-codeview.cpp (4751 of 27111)
******************** TEST 'Clang :: CodeGenCXX/debug-info-gline-tables-only-codeview.cpp' FAILED ********************
Script:

: 'RUN: at line 1'; c:\src\llvm.monorepo\build.openmp\bin\clang.exe -cc1 -internal-isystem c:\src\llvm.monorepo\build.openmp\lib\clang\12.0.0\include -nostdsysteminc c:\src\llvm.monorepo\clang\test\CodeGenCXX\debug-info-gline-tables-only-codeview.cpp -gcodeview -debug-info-kind=line-tables-only -S -emit-llvm -o - | c:\src\llvm.monorepo\build.openmp\bin\filecheck.exe c:\src\llvm.monorepo\clang\test\CodeGenCXX\debug-info-gline-tables-only-codeview.cpp

Exit Code: 1

Command Output (stdout):

$ ":" "RUN: at line 1"
$ "c:\src\llvm.monorepo\build.openmp\bin\clang.exe" "-cc1" "-internal-isystem" "c:\src\llvm.monorepo\build.openmp\lib\clang\12.0.0\include" "-nostdsysteminc" "c:\src\llvm.monorepo\clang\test\CodeGenCXX\debug-info-gline-tables-only-codeview.cpp" "-gcodeview" "-debug-info-kind=line-tables-only" "-S" "-emit-llvm" "-o" "-"
$ "c:\src\llvm.monorepo\build.openmp\bin\filecheck.exe" "c:\src\llvm.monorepo\clang\test\CodeGenCXX\debug-info-gline-tables-only-codeview.cpp"

command stderr:

c:\src\llvm.monorepo\clang\test\CodeGenCXX\debug-info-gline-tables-only-codeview.cpp:28:12: error: CHECK: expected string not found in input
// CHECK: ![[MTYPE]] = !DISubroutineType(types: !{{.*}})
^
:60:123: note: scanning from here
!​19 = !DICompositeType(tag: DW_TAG_structure_type, name: "C", scope: !​10, file: !​9, line: 7, size: 8, flags: DIFlagFwdDecl)
^
:60:123: note: with "MTYPE" equal to "20"
!​19 = !DICompositeType(tag: DW_TAG_structure_type, name: "C", scope: !​10, file: !​9, line: 7, size: 8, flags: DIFlagFwdDecl)
^
:61:1: note: possible intended match here
!​20 = !DISubroutineType(cc: DW_CC_BORLAND_thiscall, types: !​21)
^

Input file:
Check file: c:\src\llvm.monorepo\clang\test\CodeGenCXX\debug-info-gline-tables-only-codeview.cpp

-dump-input=help explains the following input dump.

Input was:
<<<<<<
.
.
.
55: !​14 = distinct !DISubprogram(name: "test", scope: !​9, file: !​9, line: 15, type: !​11, scopeLine: 15, flags: DIFlagPrototyped, spFlags: DISPFlagDefinition, unit: !​0, retainedNodes: !​2)
56: !​15 = !DILocation(line: 21, column: 3, scope: !​14)
57: !​16 = !DILocation(line: 29, column: 5, scope: !​14)
58: !​17 = !DILocation(line: 30, column: 1, scope: !​14)
59: !​18 = distinct !DISubprogram(name: "m", scope: !​19, file: !​9, line: 8, type: !​20, scopeLine: 8, flags: DIFlagPrototyped, spFlags: DISPFlagDefinition, unit: !​0, retainedNodes: !​2)
60: !​19 = !DICompositeType(tag: DW_TAG_structure_type, name: "C", scope: !​10, file: !​9, line: 7, size: 8, flags: DIFlagFwdDecl)
check:28'0 X error: no match found
check:28'1 with "MTYPE" equal to "20"
61: !​20 = !DISubroutineType(cc: DW_CC_BORLAND_thiscall, types: !​21)
check:28'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
check:28'2 ? possible intended match
62: !​21 = !{null, !​22}
check:28'0 ~~~~~~~~~~~~~~~~~~
63: !​22 = !DIDerivedType(tag: DW_TAG_pointer_type, baseType: !​19, size: 32, flags: DIFlagArtificial | DIFlagObjectPointer)
check:28'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
64: !​23 = !DILocation(line: 8, column: 13, scope: !​18)
check:28'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

error: command failed with exit status: 1

--


Testing: 0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90..


Failed Tests (1):
Clang :: CodeGenCXX/debug-info-gline-tables-only-codeview.cpp

@zmodem
Copy link
Collaborator Author

zmodem commented Jan 28, 2021

:61:1: note: possible intended match here
!​20 = !DISubroutineType(cc: DW_CC_BORLAND_thiscall, types: !​21)

I suppose the problem is that the test wasn't expecting the calling convention there... I'll see if I can just fix that real quick.

@zmodem
Copy link
Collaborator Author

zmodem commented Jan 28, 2021

0024efc should to it.

Tom, can you please merge this to the release branch?

@zmodem
Copy link
Collaborator Author

zmodem commented Jan 28, 2021

Tom, can you please merge this to the release branch?

Sorry, forgot to add the CC.

Also happy to merge myself of course if you approve.

@tstellar
Copy link
Collaborator

Merged: 99f43f5

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 11, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla Issues migrated from bugzilla clang Clang issues not falling into any other category
Projects
None yet
Development

No branches or pull requests

2 participants