Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[X86][SSE] Improve ISD::FP_TO_*INT_SAT vector lowering #51923

Open
RKSimon opened this issue Nov 22, 2021 · 4 comments
Open

[X86][SSE] Improve ISD::FP_TO_*INT_SAT vector lowering #51923

RKSimon opened this issue Nov 22, 2021 · 4 comments
Labels
backend:X86 bugzilla Issues migrated from bugzilla good first issue https://github.com/llvm/llvm-project/contribute

Comments

@RKSimon
Copy link
Collaborator

RKSimon commented Nov 22, 2021

Bugzilla Link 52581
Version trunk
OS Windows NT
CC @topperc,@DMG862,@RKSimon,@phoebewang,@rotateright

Extended Description

https://gcc.godbolt.org/z/3q7KGs6h5

We currently scalarize these cases, but we should be able to make use of SSE behaviour for out-of-range integer results to keep these fully vectorized.

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 11, 2021
@Endilll Endilll added good first issue https://github.com/llvm/llvm-project/contribute and removed beginner labels Aug 15, 2023
@llvmbot
Copy link
Collaborator

llvmbot commented Aug 15, 2023

Hi!

This issue may be a good introductory issue for people new to working on LLVM. If you would like to work on this issue, your first steps are:

  1. Assign the issue to you.
  2. Fix the issue locally.
  3. Run the test suite locally.
    3.1) Remember that the subdirectories under test/ create fine-grained testing targets, so you can
    e.g. use make check-clang-ast to only run Clang's AST tests.
  4. Create a git commit
  5. Run git clang-format HEAD~1 to format your changes.
  6. Submit the patch to Phabricator.
    6.1) Detailed instructions can be found here

For more instructions on how to submit a patch to LLVM, see our documentation.

If you have any further questions about this issue, don't hesitate to ask via a comment on this Github issue.

@llvm/issue-subscribers-good-first-issue

@RKSimon
Copy link
Collaborator Author

RKSimon commented Aug 16, 2023

Candidate Patch: https://reviews.llvm.org/D150372

@RKSimon
Copy link
Collaborator Author

RKSimon commented Mar 6, 2024

Candidate Patch: https://reviews.llvm.org/D150372

@e-kud Do you intend to resurrect this patch or might somebody else continue it?

@e-kud
Copy link
Contributor

e-kud commented Mar 11, 2024

@RKSimon let me prioritize this issue. I remember there were two problems: 1) not all fptosi+min+max can be combined into fptosi_sat but they should be 2) one of fp-int type combination wasn't convenient to support. I've tried to fix them both at once, that's why it has been stuck. I'll concentrate on fptosi_sat exclusively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend:X86 bugzilla Issues migrated from bugzilla good first issue https://github.com/llvm/llvm-project/contribute
Projects
None yet
Development

No branches or pull requests

4 participants