LLVM 24.0.0git
NVPTXTargetMachine.cpp
Go to the documentation of this file.
1//===-- NVPTXTargetMachine.cpp - Define TargetMachine for NVPTX -----------===//
2//
3// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
4// See https://llvm.org/LICENSE.txt for license information.
5// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
6//
7//===----------------------------------------------------------------------===//
8//
9// Top-level implementation for the NVPTX target.
10//
11//===----------------------------------------------------------------------===//
12
13#include "NVPTXTargetMachine.h"
14#include "NVPTX.h"
15#include "NVPTXAliasAnalysis.h"
16#include "NVPTXAsmPrinter.h"
22#include "llvm/CodeGen/Passes.h"
24#include "llvm/IR/IntrinsicsNVPTX.h"
26#include "llvm/Pass.h"
36#include <cassert>
37#include <optional>
38#include <string>
39
40using namespace llvm;
41
42// LSV is still relatively new; this switch lets us turn it off in case we
43// encounter (or suspect) a bug.
45 DisableLoadStoreVectorizer("disable-nvptx-load-store-vectorizer",
46 cl::desc("Disable load/store vectorizer"),
47 cl::init(false), cl::Hidden);
48
49// NVPTX IR Peephole is a new pass; this option will lets us turn it off in case
50// we encounter some issues.
51cl::opt<bool> DisableNVPTXIRPeephole("disable-nvptx-ir-peephole",
52 cl::desc("Disable NVPTX IR Peephole"),
53 cl::init(false), cl::Hidden);
54
55// TODO: Remove this flag when we are confident with no regressions.
57 "disable-nvptx-require-structured-cfg",
58 cl::desc("Transitional flag to turn off NVPTX's requirement on preserving "
59 "structured CFG. The requirement should be disabled only when "
60 "unexpected regressions happen."),
61 cl::init(false), cl::Hidden);
62
64 // Register the target.
67
69 // FIXME: This pass is really intended to be invoked during IR optimization,
70 // but it's very NVPTX-specific.
95}
96
98 StringRef CPU, StringRef FS,
100 std::optional<Reloc::Model> RM,
101 std::optional<CodeModel::Model> CM,
102 CodeGenOptLevel OL, bool JIT)
103 // The pic relocation model is used regardless of what the client has
104 // specified, as it is the only relocation model currently supported.
106 TT.computeDataLayout(Options.MCOptions.ABIName),
107 TT, CPU, FS, Options, Reloc::PIC_,
108 getEffectiveCodeModel(CM, CodeModel::Small), OL),
109 TLOF(std::make_unique<NVPTXTargetObjectFile>()),
110 Subtarget(TT, CPU, FS, *this), StrPool(StrAlloc) {
113 // NVPTX does not produce verifier-clean MIR yet; see isMachineVerifierClean()
114 // for the legacy pass manager equivalent.
116 initAsmInfo();
117}
118
120
121namespace {
122
123/// NVPTXPassConfig mirrors the NewPM implementation in NVPTXCodeGenPassBuilder
124/// in NVPTXCodeGenPassBuilder.cpp; the two must be kept in sync until this path
125/// is removed.
126class NVPTXPassConfig : public TargetPassConfig {
127public:
128 NVPTXPassConfig(NVPTXTargetMachine &TM, PassManagerBase &PM)
129 : TargetPassConfig(TM, PM) {}
130
131 NVPTXTargetMachine &getNVPTXTargetMachine() const {
133 }
134
135 void addIRPasses() override;
136 bool addInstSelector() override;
137 void addPreRegAlloc() override;
138 void addPostRegAlloc() override;
139
140 FunctionPass *createTargetRegisterAllocator(bool) override;
141 void addFastRegAlloc() override;
142 void addOptimizedRegAlloc() override;
143
144 bool addRegAssignAndRewriteFast() override {
145 llvm_unreachable("should not be used");
146 }
147
148 bool addRegAssignAndRewriteOptimized() override {
149 llvm_unreachable("should not be used");
150 }
151
152private:
153 // If the opt level is aggressive, add GVN; otherwise, add EarlyCSE. This
154 // function is only called in opt mode.
155 void addEarlyCSEOrGVNPass();
156
157 // Add passes that propagate special memory spaces.
158 void addAddressSpaceInferencePasses();
159
160 // Add passes that perform straight-line scalar optimizations.
161 void addStraightLineScalarOptimizationPasses();
162};
163
164} // end anonymous namespace
165
167 return new NVPTXPassConfig(*this, PM);
168}
169
176
180
183 return TargetTransformInfo(std::make_unique<NVPTXTTIImpl>(this, F));
184}
185
186std::pair<const Value *, unsigned>
188 if (auto *II = dyn_cast<IntrinsicInst>(V)) {
189 switch (II->getIntrinsicID()) {
190 case Intrinsic::nvvm_isspacep_const:
191 return std::make_pair(II->getArgOperand(0), llvm::ADDRESS_SPACE_CONST);
192 case Intrinsic::nvvm_isspacep_global:
193 return std::make_pair(II->getArgOperand(0), llvm::ADDRESS_SPACE_GLOBAL);
194 case Intrinsic::nvvm_isspacep_local:
195 return std::make_pair(II->getArgOperand(0), llvm::ADDRESS_SPACE_LOCAL);
196 case Intrinsic::nvvm_isspacep_shared:
197 return std::make_pair(II->getArgOperand(0), llvm::ADDRESS_SPACE_SHARED);
198 case Intrinsic::nvvm_isspacep_shared_cluster:
199 return std::make_pair(II->getArgOperand(0),
201 default:
202 break;
203 }
204 }
205 return std::make_pair(nullptr, -1);
206}
207
208void NVPTXPassConfig::addEarlyCSEOrGVNPass() {
209 if (getOptLevel() == CodeGenOptLevel::Aggressive)
210 // Disable scalar PRE due to Register Pressure increase
211 addPass(createGVNPass(/*ScalarPRE=*/false));
212 else
213 addPass(createEarlyCSEPass());
214}
215
216void NVPTXPassConfig::addAddressSpaceInferencePasses() {
217 // NVPTXLowerArgs emits alloca for byval parameters which can often
218 // be eliminated by SROA.
219 addPass(createSROAPass(/*PreserveCFG=*/true,
220 /*AggregateToVector=*/true));
222 // TODO: Consider running InferAddressSpaces during opt, earlier in the
223 // compilation flow.
226}
227
228void NVPTXPassConfig::addStraightLineScalarOptimizationPasses() {
231 // ReassociateGEPs exposes more opportunites for SLSR. See
232 // the example in reassociate-geps-and-slsr.ll.
234 // SeparateConstOffsetFromGEP and SLSR creates common expressions which GVN or
235 // EarlyCSE can reuse. GVN generates significantly better code than EarlyCSE
236 // for some of our benchmarks.
237 addEarlyCSEOrGVNPass();
238 // Run NaryReassociate after EarlyCSE/GVN to be more effective.
239 addPass(createNaryReassociatePass());
240 // NaryReassociate on GEPs creates redundant common expressions, so run
241 // EarlyCSE after it.
242 addPass(createEarlyCSEPass());
243}
244
245void NVPTXPassConfig::addIRPasses() {
246 // The following passes are known to not play well with virtual regs hanging
247 // around after register allocation (which in our case, is *all* registers).
248 // We explicitly disable them here. We do, however, need some functionality
249 // of the PrologEpilogCodeInserter pass, so we emulate that behavior in the
250 // NVPTXPrologEpilog pass (see NVPTXPrologEpilogPass.cpp).
251 disablePass(&PrologEpilogCodeInserterID);
252 disablePass(&MachineLateInstrsCleanupID);
253 disablePass(&MachineCopyPropagationID);
254 disablePass(&TailDuplicateLegacyID);
255 disablePass(&StackMapLivenessID);
256 disablePass(&PostRAMachineSinkingID);
257 disablePass(&PostRASchedulerID);
258 disablePass(&FuncletLayoutID);
259 disablePass(&PatchableFunctionID);
260 disablePass(&ShrinkWrapID);
261 disablePass(&RemoveLoadsIntoFakeUsesID);
262
263 addPass(createNVPTXAAWrapperPass());
265
266 // NVVMReflectPass is added in addEarlyAsPossiblePasses, so hopefully running
267 // it here does nothing. But since we need it for correctness when lowering
268 // to NVPTX, run it here too, in case whoever built our pass pipeline didn't
269 // call addEarlyAsPossiblePasses.
271 addPass(createNVVMReflectPass(ST.getSmVersion()));
272
273 if (getOptLevel() != CodeGenOptLevel::None)
277
278 // Lower variadic calls before address space inference.
280
281 // NVPTXLowerArgs is required for correctness and should be run right
282 // before the address space inference passes.
283 if (getNVPTXTargetMachine().getDrvInterface() == NVPTX::CUDA)
286 addPass(createNVPTXLowerArgsPass());
287 if (getOptLevel() != CodeGenOptLevel::None) {
288 addAddressSpaceInferencePasses();
289 addStraightLineScalarOptimizationPasses();
290 } else {
291 // Required for correct stack lowering
293 }
294
297
298 // === LSR and other generic IR passes ===
300 // EarlyCSE is not always strong enough to clean up what LSR produces. For
301 // example, GVN can combine
302 //
303 // %0 = add %a, %b
304 // %1 = add %b, %a
305 //
306 // and
307 //
308 // %0 = shl nsw %a, 2
309 // %1 = shl %a, 2
310 //
311 // but EarlyCSE can do neither of them.
312 if (getOptLevel() != CodeGenOptLevel::None) {
313 addEarlyCSEOrGVNPass();
316 addPass(createSROAPass(/*PreserveCFG=*/true,
317 /*AggregateToVector=*/true));
320 addPass(createNVPTXIRPeepholePass());
321 }
322
323 if (ST.hasPTXASUnreachableBug()) {
324 // Run LowerUnreachable to WAR a ptxas bug. See the commit description of
325 // 1ee4d880e8760256c606fe55b7af85a4f70d006d for more details.
326 const auto &Options = getNVPTXTargetMachine().Options;
327 addPass(createNVPTXLowerUnreachableLegacyPass(Options.TrapUnreachable,
328 Options.NoTrapAfterNoreturn));
329 }
330}
331
332bool NVPTXPassConfig::addInstSelector() {
335 addPass(createNVPTXISelDag(getNVPTXTargetMachine(), getOptLevel()));
337
338 return false;
339}
340
341void NVPTXPassConfig::addPreRegAlloc() {
343 if (getOptLevel() != CodeGenOptLevel::None)
345 // Remove Proxy Register pseudo instructions used to keep `callseq_end` alive.
347}
348
349void NVPTXPassConfig::addPostRegAlloc() {
351 if (getOptLevel() != CodeGenOptLevel::None) {
352 // NVPTXPrologEpilogPass calculates frame object offset and replace frame
353 // index with VRFrame register. NVPTXPeephole need to be run after that and
354 // will replace VRFrame with VRFrameLocal when possible.
356 }
357}
358
359FunctionPass *NVPTXPassConfig::createTargetRegisterAllocator(bool) {
360 return nullptr; // No reg alloc
361}
362
363void NVPTXPassConfig::addFastRegAlloc() {
364 addPass(&PHIEliminationID);
366}
367
368void NVPTXPassConfig::addOptimizedRegAlloc() {
369 addPass(&ProcessImplicitDefsID);
370 addPass(&LiveVariablesID);
371 addPass(&MachineLoopInfoID);
372 addPass(&PHIEliminationID);
373
375 addPass(&RegisterCoalescerID);
376
377 // PreRA instruction scheduling.
378 if (addPass(&MachineSchedulerID))
379 printAndVerify("After Machine Scheduling");
380
381 addPass(&StackSlotColoringID);
382
383 // FIXME: Needs physical registers
384 // addPass(&MachineLICMID);
385
386 printAndVerify("After StackSlotColoring");
387}
#define X(NUM, ENUM, NAME)
Definition ELF.h:856
#define LLVM_ABI
Definition Compiler.h:215
#define LLVM_EXTERNAL_VISIBILITY
Definition Compiler.h:132
This file provides the interface for LLVM's Global Value Numbering pass which eliminates fully redund...
static LVOptions Options
Definition LVOptions.cpp:25
#define F(x, y, z)
Definition MD5.cpp:54
#define T
This is the NVPTX address space based alias analysis pass.
cl::opt< bool > DisableNVPTXIRPeephole
cl::opt< bool > DisableLoadStoreVectorizer
cl::opt< bool > DisableLoadStoreVectorizer("disable-nvptx-load-store-vectorizer", cl::desc("Disable load/store vectorizer"), cl::init(false), cl::Hidden)
static cl::opt< bool > DisableRequireStructuredCFG("disable-nvptx-require-structured-cfg", cl::desc("Transitional flag to turn off NVPTX's requirement on preserving " "structured CFG. The requirement should be disabled only when " "unexpected regressions happen."), cl::init(false), cl::Hidden)
cl::opt< bool > DisableNVPTXIRPeephole("disable-nvptx-ir-peephole", cl::desc("Disable NVPTX IR Peephole"), cl::init(false), cl::Hidden)
LLVM_ABI LLVM_EXTERNAL_VISIBILITY void LLVMInitializeNVPTXTarget()
This file a TargetTransformInfoImplBase conforming object specific to the NVPTX target machine.
uint64_t IntrinsicInst * II
const GCNTargetMachine & getTM(const GCNSubtarget *STI)
static TableGen::Emitter::Opt Y("gen-skeleton-entry", EmitSkeleton, "Generate example skeleton entry")
Target-Independent Code Generator Pass Configuration Options pass.
This pass exposes codegen information to IR-level passes.
A manager for alias analyses.
void registerFunctionAnalysis()
Register a specific AA result.
CodeGenTargetMachineImpl(const Target &T, StringRef DataLayoutString, const Triple &TT, StringRef CPU, StringRef FS, const TargetOptions &Options, Reloc::Model RM, CodeModel::Model CM, CodeGenOptLevel OL)
FunctionPass class - This class is used to implement most global optimizations.
Definition Pass.h:314
const TargetSubtargetInfo * getSubtargetImpl(const Function &) const override
Virtual method implemented by subclasses that returns a reference to that target's TargetSubtargetInf...
Analysis pass providing a never-invalidated alias analysis result.
NVPTXTargetMachine(const Target &T, const Triple &TT, StringRef CPU, StringRef FS, const TargetOptions &Options, std::optional< Reloc::Model > RM, std::optional< CodeModel::Model > CM, CodeGenOptLevel OL, bool JIT)
TargetTransformInfo getTargetTransformInfo(const Function &F) const override
Get a TargetTransformInfo implementation for the target.
std::pair< const Value *, unsigned > getPredicatedAddrSpace(const Value *V) const override
If the specified predicate checks whether a generic pointer falls within a specified address space,...
void registerEarlyDefaultAliasAnalyses(AAManager &AAM) override
Allow the target to register early alias analyses (AA before BasicAA) with the AAManager for use with...
~NVPTXTargetMachine() override
MachineFunctionInfo * createMachineFunctionInfo(BumpPtrAllocator &Allocator, const Function &F, const TargetSubtargetInfo *STI) const override
Create the target's instance of MachineFunctionInfo.
TargetPassConfig * createPassConfig(PassManagerBase &PM) override
Create a pass configuration object to be used by addPassToEmitX methods for generating a pipeline of ...
PassRegistry - This class manages the registration and intitialization of the pass subsystem as appli...
static LLVM_ABI PassRegistry * getPassRegistry()
getPassRegistry - Access the global registry object, which is automatically initialized at applicatio...
Represent a constant reference to a string, i.e.
Definition StringRef.h:56
void setRequiresStructuredCFG(bool Value)
std::unique_ptr< const MCSubtargetInfo > STI
TargetOptions Options
void setEnableDefaultMachineVerifier(bool Enable)
Target-Independent Code Generator Pass Configuration Options.
virtual void addIRPasses()
Add common target configurable passes that perform LLVM IR to IR transforms following machine indepen...
TargetSubtargetInfo - Generic base class for all target subtargets.
This pass provides access to the codegen interfaces that are needed for IR-level transformations.
Target - Wrapper for Target specific information.
Triple - Helper class for working with autoconf configuration names.
Definition Triple.h:48
LLVM Value Representation.
Definition Value.h:75
PassManagerBase - An abstract interface to allow code to add passes to a pass manager without having ...
#define llvm_unreachable(msg)
Marks that the current location is not supposed to be reachable.
initializer< Ty > init(const Ty &Val)
This is an optimization pass for GlobalISel generic memory operations.
FunctionPass * createNVPTXLowerUnreachableLegacyPass(bool TrapUnreachable, bool NoTrapAfterNoreturn)
FunctionPass * createNVPTXIRPeepholePass()
FunctionPass * createNVPTXAtomicLowerLegacyPass()
FunctionPass * createNVPTXImageOptimizerLegacyPass()
void initializeNVPTXLowerUnreachableLegacyPassPass(PassRegistry &)
LLVM_ABI char & RegisterCoalescerID
RegisterCoalescer - This pass merges live ranges to eliminate copies.
decltype(auto) dyn_cast(const From &Val)
dyn_cast<X> - Return the argument parameter cast to the specified type.
Definition Casting.h:643
ModulePass * createGenericToNVVMLegacyPass()
void initializeNVPTXExternalAAWrapperPass(PassRegistry &)
void initializeNVPTXPeepholeLegacyPassPass(PassRegistry &)
void initializeNVPTXPrologEpilogLegacyPassPass(PassRegistry &)
LLVM_ABI char & TailDuplicateLegacyID
TailDuplicate - Duplicate blocks with unconditional branches into tails of their predecessors.
LLVM_ABI Pass * createLoadStoreVectorizerPass()
Create a legacy pass manager instance of the LoadStoreVectorizer pass.
LLVM_ABI FunctionPass * createNaryReassociatePass()
LLVM_ABI char & PatchableFunctionID
This pass implements the "patchable-function" attribute.
ImmutablePass * createNVPTXExternalAAWrapperPass()
void initializeNVPTXLowerArgsLegacyPassPass(PassRegistry &)
LLVM_ABI char & PostRASchedulerID
PostRAScheduler - This pass performs post register allocation scheduling.
LLVM_ABI char & RemoveLoadsIntoFakeUsesID
RemoveLoadsIntoFakeUses pass.
MachineFunctionPass * createNVPTXReplaceImageHandlesLegacyPass()
void initializeNVPTXForwardParamsLegacyPassPass(PassRegistry &)
FunctionPass * createNVPTXLowerAggrCopiesLegacyPass()
ModulePass * createNVPTXAssignValidGlobalNamesLegacyPass()
LLVM_ABI char & MachineSchedulerID
MachineScheduler - This pass schedules machine instructions.
void initializeNVPTXAssignValidGlobalNamesLegacyPassPass(PassRegistry &)
FunctionPass * createNVPTXISelDag(NVPTXTargetMachine &TM, llvm::CodeGenOptLevel OptLevel)
createNVPTXISelDag - This pass converts a legalized DAG into a NVPTX-specific DAG,...
LLVM_ABI char & PrologEpilogCodeInserterID
PrologEpilogCodeInserter - This pass inserts prolog and epilog code, and eliminates abstract frame re...
MachineFunctionPass * createNVPTXAddressFolderLegacyPass()
void initializeNVPTXLowerAllocaLegacyPassPass(PassRegistry &)
void initializeGenericToNVVMLegacyPassPass(PassRegistry &)
void initializeNVPTXCtorDtorLoweringLegacyPass(PassRegistry &)
MachineFunctionPass * createNVPTXForwardParamsLegacyPass()
FunctionPass * createNVPTXTagInvariantLoadsPass()
LLVM_ABI char & MachineLoopInfoID
MachineLoopInfo - This pass is a loop analysis pass.
void initializeNVVMReflectLegacyPassPass(PassRegistry &)
void initializeNVPTXAddressFolderLegacyPassPass(PassRegistry &)
CodeModel::Model getEffectiveCodeModel(std::optional< CodeModel::Model > CM, CodeModel::Model Default)
Helper method for getting the code model, returning Default if CM does not have a value.
LLVM_ABI ModulePass * createExpandVariadicsPass(ExpandVariadicsMode)
LLVM_ABI char & ShrinkWrapID
ShrinkWrap pass. Look for the best place to insert save and restore.
LLVM_ABI char & MachineLateInstrsCleanupID
MachineLateInstrsCleanup - This pass removes redundant identical instructions after register allocati...
void initializeNVPTXAAWrapperPassPass(PassRegistry &)
void initializeNVPTXIRPeepholePass(PassRegistry &)
ModulePass * createNVPTXLowerArgsPass()
LLVM_ABI FunctionPass * createSpeculativeExecutionPass()
LLVM_ABI char & StackMapLivenessID
StackMapLiveness - This pass analyses the register live-out set of stackmap/patchpoint intrinsics and...
FunctionPass * createNVPTXMarkKernelPtrsGlobalPass()
LLVM_ABI char & FuncletLayoutID
This pass lays out funclets contiguously.
void initializeNVVMIntrRangePass(PassRegistry &)
MachineFunctionPass * createNVPTXPrologEpilogLegacyPass()
LLVM_ABI char & PostRAMachineSinkingID
This pass perform post-ra machine sink for COPY instructions.
CodeGenOptLevel
Code generation optimization level.
Definition CodeGen.h:149
void initializeNVPTXLowerAggrCopiesLegacyPassPass(PassRegistry &)
LLVM_ABI char & StackSlotColoringID
StackSlotColoring - This pass performs stack slot coloring.
ModulePass * createNVPTXPromoteParamAlignPass()
void initializeNVPTXAsmPrinterPass(PassRegistry &)
LLVM_ABI FunctionPass * createSeparateConstOffsetFromGEPPass(bool LowerGEP=false)
void initializeNVPTXProxyRegErasureLegacyPassPass(PassRegistry &)
LLVM_ABI char & ProcessImplicitDefsID
ProcessImpicitDefs pass - This pass removes IMPLICIT_DEFs.
void initializeNVPTXTagInvariantLoadLegacyPassPass(PassRegistry &)
void initializeNVPTXAtomicLowerLegacyPassPass(PassRegistry &)
MachineFunctionPass * createNVPTXPeepholeLegacyPass()
LLVM_ABI FunctionPass * createGVNPass()
Definition GVN.cpp:4065
FunctionPass * createNVPTXLowerAllocaLegacyPass()
ModulePass * createNVPTXCtorDtorLoweringLegacyPass()
void initializeNVPTXMarkKernelPtrsGlobalLegacyPassPass(PassRegistry &)
LLVM_ABI char & LiveVariablesID
LiveVariables pass - This pass computes the set of blocks in which each variable is life and sets mac...
LLVM_ABI FunctionPass * createSROAPass(bool PreserveCFG=true, bool AggregateToVector=false)
Definition SROA.cpp:6408
Target & getTheNVPTXTarget64()
LLVM_ABI FunctionPass * createInferAddressSpacesPass(unsigned AddressSpace=~0u)
void initializeNVPTXAllocaHoistingLegacyPassPass(PassRegistry &)
ImmutablePass * createNVPTXAAWrapperPass()
FunctionPass * createNVPTXAllocaHoistingLegacyPass()
ModulePass * createNVVMReflectPass(unsigned int SmVersion)
LLVM_ABI char & TwoAddressInstructionPassID
TwoAddressInstruction - This pass reduces two-address instructions to use two operands.
void initializeNVPTXPromoteParamAlignLegacyPassPass(PassRegistry &)
LLVM_ABI FunctionPass * createAtomicExpandLegacyPass()
AtomicExpandPass - At IR level this pass replace atomic instructions with __atomic_* library calls,...
LLVM_ABI FunctionPass * createStraightLineStrengthReducePass()
BumpPtrAllocatorImpl<> BumpPtrAllocator
The standard BumpPtrAllocator which just uses the default template parameters.
Definition Allocator.h:390
LLVM_ABI FunctionPass * createEarlyCSEPass(bool UseMemorySSA=false)
LLVM_ABI char & PHIEliminationID
PHIElimination - This pass eliminates machine instruction PHI nodes by inserting copy instructions.
MachineFunctionPass * createNVPTXProxyRegErasureLegacyPass()
LLVM_ABI char & MachineCopyPropagationID
MachineCopyPropagation - This pass performs copy propagation on machine instructions.
Target & getTheNVPTXTarget32()
void initializeNVPTXDAGToDAGISelLegacyPass(PassRegistry &)
Implement std::hash so that hash_code can be used in STL containers.
Definition BitVector.h:878
MachineFunctionInfo - This class can be derived from and used by targets to hold private target-speci...
static FuncInfoTy * create(BumpPtrAllocator &Allocator, const Function &F, const SubtargetTy *STI)
Factory function: default behavior is to call new using the supplied allocator.
RegisterTargetMachine - Helper template for registering a target machine implementation,...